[webkit-reviews] review granted: [Bug 215684] [Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so there's no need to consult it in Cocoa-specific files : [Attachment 406908] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 215684: [Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa
platforms, so there's no need to consult it in Cocoa-specific files
https://bugs.webkit.org/show_bug.cgi?id=215684

Attachment 406908: Patch

https://bugs.webkit.org/attachment.cgi?id=406908&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406908
  --> https://bugs.webkit.org/attachment.cgi?id=406908
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406908&action=review

> Source/WebCore/platform/graphics/FontCascadeDescription.cpp:66
> -#if !USE(PLATFORM_SYSTEM_FALLBACK_LIST)
> +#if !PLATFORM(COCOA)

I feel like any time we change an #if to literally check PLATFORM instead of a
feature, it’s a small step backward.