[webkit-reviews] review granted: [Bug 215663] Blob is missing text() & arrayBuffer() operations : [Attachment 406877] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 19 15:36:36 PDT 2020
Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215663: Blob is missing text() & arrayBuffer() operations
https://bugs.webkit.org/show_bug.cgi?id=215663
Attachment 406877: Patch
https://bugs.webkit.org/attachment.cgi?id=406877&action=review
--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 406877
--> https://bugs.webkit.org/attachment.cgi?id=406877
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=406877&action=review
r=me
> Source/WebCore/fileapi/NetworkSendQueue.cpp:74
> + blobLoaderPtr->start(blob, m_document.get(),
FileReaderLoader::ReadAsArrayBuffer);
Could use m_queue.last() here instead of blobLoaderPtr. Not sure if that's
obviously better; but taking a raw pointer to a UniqueRef smells bad.
> Source/WebCore/page/ShareDataReader.cpp:58
> + blobLoaderPtr->start(*blob, document,
FileReaderLoader::ReadAsArrayBuffer);
Here too.
More information about the webkit-reviews
mailing list