[webkit-reviews] review granted: [Bug 215595] Third party domains are not stored in the case of back/forward navigations : [Attachment 406865] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 15:16:56 PDT 2020


Chris Dumez <cdumez at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 215595: Third party domains are not stored in the case of back/forward
navigations
https://bugs.webkit.org/show_bug.cgi?id=215595

Attachment 406865: Patch

https://bugs.webkit.org/attachment.cgi?id=406865&action=review




--- Comment #24 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 406865
  --> https://bugs.webkit.org/attachment.cgi?id=406865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406865&action=review

r=me with nit fix. Please address naming issue raised by Darin & Sam before
landing too.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6836
> +const HashSet<WebCore::RegistrableDomain>&
WebPage::loadedThirdPartyDomains() const

This could be inlined in the header given how trivial it is.


More information about the webkit-reviews mailing list