[webkit-reviews] review granted: [Bug 215660] [Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode. : [Attachment 406869] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 215660: [Mac] REGRESSION(r262322): Focusable elements are focused when
exiting from video fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=215660

Attachment 406869: Patch

https://bugs.webkit.org/attachment.cgi?id=406869&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406869
  --> https://bugs.webkit.org/attachment.cgi?id=406869
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406869&action=review

> Source/WebKit/ChangeLog:12
> +	   The default behavior of NSWindow is to change its
-keyViewSelectionDirection to NSSelectingNext when activating
> +	   and changing the firstResponder. This causes WKWebView to change
it's focus in response to becoming first responder.
> +	   The cheap fix is to ensure WKWebView is already the firstResponder
when the window is activated. Then NSWindow won't
> +	   try to change the firstResponder in response to activation.

Regression test?