[webkit-reviews] review requested: [Bug 150392] [GTK] Implement rendering frames timeline panel for GTK+ port : [Attachment 406841] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 05:22:21 PDT 2020


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 150392: [GTK] Implement rendering frames timeline panel for GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=150392

Attachment 406841: Patch

https://bugs.webkit.org/attachment.cgi?id=406841&action=review




--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 406841

  --> https://bugs.webkit.org/attachment.cgi?id=406841&action=review

Patch

This patch follows the run loop approach. We can't monitor the run loop because
GLib doesn't have API for that, but we can at least monitor our sources, which
seems to be enough to get quite useful information. It's not exactly a frame
per loop cycle in some cases, because here we are monitoring the sources, but
in most of the cases there's only one source per loop iteration.


More information about the webkit-reviews mailing list