[webkit-reviews] review granted: [Bug 215616] [WebGL2] Various parameters should be non-nullable in IDL : [Attachment 406818] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 15:35:20 PDT 2020


Darin Adler <darin at apple.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 215616: [WebGL2] Various parameters should be non-nullable in IDL
https://bugs.webkit.org/show_bug.cgi?id=215616

Attachment 406818: Patch

https://bugs.webkit.org/attachment.cgi?id=406818&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 406818
  --> https://bugs.webkit.org/attachment.cgi?id=406818
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review

> LayoutTests/ChangeLog:17
> +	   * fast/canvas/webgl/context-lost-expected.txt:
> +	   * fast/canvas/webgl/context-lost.html:
> +	   * fast/canvas/webgl/error-reporting-expected.txt:
> +	   * fast/canvas/webgl/error-reporting.html:
> +	   * fast/canvas/webgl/get-active-test-expected.txt:
> +	   * fast/canvas/webgl/get-active-test.html:
> +	   * fast/canvas/webgl/gl-object-get-calls-expected.txt:
> +	   * fast/canvas/webgl/gl-object-get-calls.html:
> +	   * fast/canvas/webgl/null-object-behaviour-expected.txt:
> +	   * fast/canvas/webgl/null-object-behaviour.html:

If any of these are redundant tests, you should feel free to cut them down.


More information about the webkit-reviews mailing list