[webkit-reviews] review granted: [Bug 215625] PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear" : [Attachment 406814] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215625: PannerNode's rolloffFactor should be clamped to [0, 1] internally
when distanceModel is "linear"
https://bugs.webkit.org/show_bug.cgi?id=215625

Attachment 406814: Patch

https://bugs.webkit.org/attachment.cgi?id=406814&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406814
  --> https://bugs.webkit.org/attachment.cgi?id=406814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406814&action=review

>> Source/WebCore/platform/audio/Distance.cpp:72
>> +	auto clampedRolloffFactor = std::min(m_rolloffFactor, 1.0);
> 
> This says clamped but it only does the 1.0 half of the clamping. I’d expect
to see std::max or std::clamp here.

to handle the 0.0 minimum.