[webkit-reviews] review granted: [Bug 215626] WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads : [Attachment 406811] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 215626: WKWebViews using fastServerTrustEvaluationEnabled should only allow
legacy TLS for main resource loads
https://bugs.webkit.org/show_bug.cgi?id=215626

Attachment 406811: Patch

https://bugs.webkit.org/attachment.cgi?id=406811&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 406811
  --> https://bugs.webkit.org/attachment.cgi?id=406811
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406811&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:397
> +    if (negotiatedLegacyTLS == NegotiatedLegacyTLS::Yes
> +	   && fastServerTrustEvaluationEnabled
> +	   && !isTopLevelNavigation())
> +	   return completionHandler(AuthenticationChallengeDisposition::Cancel,
{ });

Why not do this in NetworkSessionCocoa::continueDidReceiveChallenge rather than
passing more state through?