[webkit-reviews] review granted: [Bug 215624] ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext : [Attachment 406808] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 215624: ScriptProcessNode should only run script asynchronously if the
audio context is not an OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=215624

Attachment 406808: Patch

https://bugs.webkit.org/attachment.cgi?id=406808&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 406808
  --> https://bugs.webkit.org/attachment.cgi?id=406808
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406808&action=review

> Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:214
> +		       // De-reference to match the ref() call in process().

Nit: it is a little odd to have this comment only on the second `deref()`