[webkit-reviews] review granted: [Bug 215619] [macOS] Move stepper painting code off of Carbon API : [Attachment 406802] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Aditya Keerthi <akeerthi at apple.com>'s
request for review:
Bug 215619: [macOS] Move stepper painting code off of Carbon API
https://bugs.webkit.org/show_bug.cgi?id=215619

Attachment 406802: Patch

https://bugs.webkit.org/attachment.cgi?id=406802&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406802
  --> https://bugs.webkit.org/attachment.cgi?id=406802
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406802&action=review

We should figure out how to make test coverage for this.

> Source/WebCore/platform/mac/ThemeMac.mm:637
> +    ControlStates::States states = controlStates.states();

Consider auto here instead of writing out the type ControlStates::States

> Source/WebCore/platform/mac/ThemeMac.mm:672
> +	   (__bridge NSString *)kCUIWidgetKey: (__bridge NSString
*)kCUIWidgetButtonLittleArrows,
> +	   (__bridge NSString *)kCUISizeKey: coreUISize,
> +	   (__bridge NSString *)kCUIStateKey: coreUIState,
> +	   (__bridge NSString *)kCUIValueKey: (states &
ControlStates::SpinUpState) ? @1 : @0,
> +	   (__bridge NSString *)kCUIIsFlippedKey : @NO,
> +	   (__bridge NSString *)kCUIScaleKey : @1,
> +	   (__bridge NSString *)kCUIMaskOnlyKey : @NO

Mixed formatting here about whether the ":" has a space before it or not.