[webkit-reviews] review granted: [Bug 215575] Do not shrink radio buttons bellow its size : [Attachment 406726] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 215575: Do not shrink radio buttons bellow its size
https://bugs.webkit.org/show_bug.cgi?id=215575

Attachment 406726: Patch

https://bugs.webkit.org/attachment.cgi?id=406726&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 406726
  --> https://bugs.webkit.org/attachment.cgi?id=406726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406726&action=review

>>> Source/WebCore/rendering/RenderTheme.cpp:183
>>> +	     }
>> 
>> Why are we doing this here instead of inside the minimumControlSize
function?
>> 
>> I’m not saying this is wrong, but I want to understand how we made the call.
> 
> For two reasons:
> 1) by doing it here we don't need to reimplement it for all platforms
> 2) the minimumControlSize function only receives the style.minHeight/minWidth
but we also need the style.height/width
> 
> None of them are indeed blockers to implement it in minimumControlSize (we
could pass the style.width/height) which I agree would look much better, but
reimplementing it for all the platforms didn't appeal much to me.

The special case for RadioPart doesn’t feel consistent with the style of the
rest of this function. In future (does not need to block this patch) think we
should strive for a better factoring. But we should definitely *not* refactor
so every platform has to do it separately!