[webkit-reviews] review granted: [Bug 215569] [Cocoa] Avoid waiting for Launch Services on every load : [Attachment 406715] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 17 14:13:16 PDT 2020
Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 215569: [Cocoa] Avoid waiting for Launch Services on every load
https://bugs.webkit.org/show_bug.cgi?id=215569
Attachment 406715: Patch
https://bugs.webkit.org/attachment.cgi?id=406715&action=review
--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406715
--> https://bugs.webkit.org/attachment.cgi?id=406715
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=406715&action=review
> Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:69
> + static std::once_flag onceFlag;
> + std::call_once(onceFlag, [] {
This is a multi-thread-safe way of doing this. Can this be called from multiple
threads? If not, a simple global check would suffice.
More information about the webkit-reviews
mailing list