[webkit-reviews] review granted: [Bug 215578] AudioNode.disconnect() does not match the specification : [Attachment 406739] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 215578: AudioNode.disconnect() does not match the specification
https://bugs.webkit.org/show_bug.cgi?id=215578

Attachment 406739: Patch

https://bugs.webkit.org/attachment.cgi?id=406739&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 406739
  --> https://bugs.webkit.org/attachment.cgi?id=406739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406739&action=review

> Source/WebCore/ChangeLog:9
> +	   AudioNode.disconnect() did not match the specification. There were a
lot of overloads in
> +	   the specification that we do not support:

There is a minor tense problem here, should either be "There were ... that we
did not..." or "There are ... that we do not ..."