[webkit-reviews] review granted: [Bug 215563] NetworkSocketChannel should delay sending back error message as done by NetworkSocketStream : [Attachment 406709] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 215563: NetworkSocketChannel should delay sending back error message as
done by NetworkSocketStream
https://bugs.webkit.org/show_bug.cgi?id=215563

Attachment 406709: Patch

https://bugs.webkit.org/attachment.cgi?id=406709&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 406709
  --> https://bugs.webkit.org/attachment.cgi?id=406709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406709&action=review

> Source/WebKit/NetworkProcess/NetworkSocketChannel.h:94
> +    String m_errorMessage;

It would be nice if we could make a version of Timer::startOneShot that takes a
lambda so these could be in a lambda capture instead of members of this object.

> Source/WebKit/NetworkProcess/NetworkSocketChannel.h:95
> +    Optional<std::pair<unsigned short, String>> m_closeInfo;

Could we make this uint16_t?