[webkit-reviews] review granted: [Bug 215349] Clean up DragApplicationFlags after switch to OptionSet<> : [Attachment 406667] Patch v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 215349: Clean up DragApplicationFlags after switch to OptionSet<>
https://bugs.webkit.org/show_bug.cgi?id=215349

Attachment 406667: Patch v2

https://bugs.webkit.org/attachment.cgi?id=406667&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 406667
  --> https://bugs.webkit.org/attachment.cgi?id=406667
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=406667&action=review

Seems like a GTK test related to the patch failed. I pushed the retry button so
it would try again.

> Source/WebCore/platform/DragData.h:61
> +enum class DragApplicationFlags : uint8_t {

The enum represents a single flag. Doesn’t make sense to call it "flags". An
OptionSet, of course, contains multiple flags. So this should be renamed
DragApplicationFlag, singular.