[webkit-reviews] review granted: [Bug 215533] [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing : [Attachment 406647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 15 09:32:21 PDT 2020


youenn fablet <youennf at gmail.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 215533: [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
https://bugs.webkit.org/show_bug.cgi?id=215533

Attachment 406647: Patch

https://bugs.webkit.org/attachment.cgi?id=406647&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 406647
  --> https://bugs.webkit.org/attachment.cgi?id=406647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406647&action=review

> Source/WebCore/svg/graphics/SVGImage.cpp:175
> +	   return IntSize(300, 150);

Are these values used elsewhere? Is it worth using constants or a specific
routine to document/centralize these values?


More information about the webkit-reviews mailing list