[webkit-reviews] review granted: [Bug 215529] Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s : [Attachment 406641] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 215529: Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s
https://bugs.webkit.org/show_bug.cgi?id=215529

Attachment 406641: Patch

https://bugs.webkit.org/attachment.cgi?id=406641&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 406641
  --> https://bugs.webkit.org/attachment.cgi?id=406641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406641&action=review

r=me

> Source/WebCore/page/scrolling/ScrollingTree.h:212
> +    bool isRecentlyActive();
> +    WEBCORE_EXPORT void setRecentlyActive();

Should we make these names more specific to wheel events?

isProcessingWheelEvent()
willProcessWheelEvent()

> Source/WebCore/page/scrolling/ScrollingTree.h:278
> +    Lock m_lastEventTimeMutex;
> +    MonotonicTime m_lastEventTime;

Should we make these names more specific to wheel events?

m_lastWheelEventTimeMutex
m_lastWheelEventTime