[webkit-reviews] review granted: [Bug 215487] Have an OOB+SaneChain Array::Speculation : [Attachment 406651] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 20:36:00 PDT 2020


Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 215487: Have an OOB+SaneChain Array::Speculation
https://bugs.webkit.org/show_bug.cgi?id=215487

Attachment 406651: patch

https://bugs.webkit.org/attachment.cgi?id=406651&action=review




--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 406651
  --> https://bugs.webkit.org/attachment.cgi?id=406651
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406651&action=review

r=me with one comment.

> Source/JavaScriptCore/dfg/DFGClobberize.h:945
> +		   LocationKind kind = mode.isInBoundsSaneChain() ?
IndexedPropertyDoubleSaneChainLoc : IndexedPropertyDoubleLoc;

This means that we will use IndexedPropertyDoubleLoc for OutOfBoundsSaneChain,
is it correct?


More information about the webkit-reviews mailing list