[webkit-reviews] review granted: [Bug 215528] [JSC] attribute-change transition should not pin Structure : [Attachment 406649] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 19:35:59 PDT 2020


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 215528: [JSC] attribute-change transition should not pin Structure
https://bugs.webkit.org/show_bug.cgi?id=215528

Attachment 406649: Patch

https://bugs.webkit.org/attachment.cgi?id=406649&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 406649
  --> https://bugs.webkit.org/attachment.cgi?id=406649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406649&action=review

> Source/JavaScriptCore/runtime/Structure.cpp:492
> +    if (structure->hasBeenDictionary())

maybe just an explanation why this is the way  it is and why it's not
profitable to do the other thing


More information about the webkit-reviews mailing list