[webkit-reviews] review granted: [Bug 215516] RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text element : [Attachment 406625] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 14 15:18:09 PDT 2020
Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 215516: RenderTextControlSingleLine::scroll* functions should not call
Element::scroll* on the inner text element
https://bugs.webkit.org/show_bug.cgi?id=215516
Attachment 406625: Patch
https://bugs.webkit.org/attachment.cgi?id=406625&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 406625
--> https://bugs.webkit.org/attachment.cgi?id=406625
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=406625&action=review
> Source/WebCore/ChangeLog:10
> + The clients of these functions expect the geometry data to be inline
with the rest of the rendering context
in-line or "agree with"? "inline" here confusing in this context.
More information about the webkit-reviews
mailing list