[webkit-reviews] review granted: [Bug 215417] Add support for suspending / resuming an OfflineAudioContext : [Attachment 406552] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 215417: Add support for suspending / resuming an OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=215417

Attachment 406552: Patch

https://bugs.webkit.org/attachment.cgi?id=406552&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 406552
  --> https://bugs.webkit.org/attachment.cgi?id=406552
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406552&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:659
>      // Don't allow regular lock in real-time audio thread.

This comment is not accurate when shouldAllowLockingOnAudioThread ==
ShouldAllowLockingOnAudioThread::Yes

> Source/WebCore/Modules/webaudio/BaseAudioContext.h:208
> +    enum class ShouldAllowLockingOnAudioThread { No, Yes };

It seems like there should be a comment here with a stern warning about using
this.