[webkit-reviews] review granted: [Bug 215501] WritableStream rejected promises should be marked as handled as per spec : [Attachment 406589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 10:47:59 PDT 2020


Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 215501: WritableStream rejected promises should be marked as handled as per
spec
https://bugs.webkit.org/show_bug.cgi?id=215501

Attachment 406589: Patch

https://bugs.webkit.org/attachment.cgi?id=406589&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 406589
  --> https://bugs.webkit.org/attachment.cgi?id=406589
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406589&action=review

> Source/WebCore/Modules/streams/WritableStreamInternals.js:72
> +	   @putPromiseInternalField(readyPromiseCapability. at promise,
@promiseFieldFlags, @getPromiseInternalField(readyPromiseCapability. at promise,
@promiseFieldFlags) | @promiseFlagsIsHandled);

Frustrating that this long line of code is repeated 6 times. Is there a way to
do this that is less wordy and repetitive, but is also still efficient?


More information about the webkit-reviews mailing list