[webkit-reviews] review granted: [Bug 215510] AudioBufferSourceNode.buffer setter should throw when the buffer was already set : [Attachment 406599] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215510: AudioBufferSourceNode.buffer setter should throw when the buffer
was already set
https://bugs.webkit.org/show_bug.cgi?id=215510

Attachment 406599: Patch

https://bugs.webkit.org/attachment.cgi?id=406599&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 406599
  --> https://bugs.webkit.org/attachment.cgi?id=406599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406599&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:55
>      // returns true on success.

This comment seems wrong.

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:101
> +    virtual bool isWebKitAudioBufferSourceNode() const { return false; }

This is a little ugly. I guess it’s how we do dynamic type checks, but I could
imagine this being a policy function — "can set buffer twice" or whatever —
rather than a type check function.