[webkit-reviews] review granted: [Bug 215513] Fix bad check in AudioBufferSourceNode::renderFromBuffer() : [Attachment 406602] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 10:43:43 PDT 2020


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215513: Fix bad check in AudioBufferSourceNode::renderFromBuffer()
https://bugs.webkit.org/show_bug.cgi?id=215513

Attachment 406602: Patch

https://bugs.webkit.org/attachment.cgi?id=406602&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 406602
  --> https://bugs.webkit.org/attachment.cgi?id=406602
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406602&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:249
> +    if (fabs(pitchRate) > virtualDeltaFrames)

std::abs is better than fabs


More information about the webkit-reviews mailing list