[webkit-reviews] review granted: [Bug 215503] [GTK][WPE] Remove support for NPAPI plugins : [Attachment 406594] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 10:42:01 PDT 2020


Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 215503: [GTK][WPE] Remove support for NPAPI plugins
https://bugs.webkit.org/show_bug.cgi?id=215503

Attachment 406594: Patch

https://bugs.webkit.org/attachment.cgi?id=406594&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406594
  --> https://bugs.webkit.org/attachment.cgi?id=406594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406594&action=review

> LayoutTests/platform/glib/TestExpectations:956
> +# Plugins

Here’s a follow-up task that’s helpful for clarity and the future, but is a
little extra work because of the platforms that still do have the plug-in
support around.

Seems like it’s worthwhile to *move* these tests all into the plugins and
http/tests/plugins directories.

Except for the tests that just *happen* to use plug-ins that could be redone to
test the same thing without a plug-in. Those we could *copy* into the plugins
or http/tests/plugins directory and modify (and possibly rename) the original
to not use plug-ins any more.

It could be a little bit of a pain to do those moves, but I think it’s good for
the health of the project. And it would also make this skipping only two lines
long.

The alternative is to wait until we can delete plug-in support on all
platforms, then we can delete instead of moving.


More information about the webkit-reviews mailing list