[webkit-reviews] review granted: [Bug 214890] Cache Structure::attributeChangeTransition() : [Attachment 406557] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 214890: Cache Structure::attributeChangeTransition()
https://bugs.webkit.org/show_bug.cgi?id=214890

Attachment 406557: Patch

https://bugs.webkit.org/attachment.cgi?id=406557&action=review




--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 406557
  --> https://bugs.webkit.org/attachment.cgi?id=406557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406557&action=review

r=me

> Source/JavaScriptCore/runtime/Structure.cpp:754
> +    transition->pin(holdLock(transition->m_lock), vm, table);

Yes, this pinning is important in this patch since this prevents
`forEachPropertyConcurrently` to traversing this attribute-change transition
(because this structure is pinned).
We should later extend it to avoid pinning. And use `pinForCaching` to keep
transition count. For dictionary, we should pin.