[webkit-reviews] review denied: [Bug 215377] Introduce ConstantSourceNode Interface : [Attachment 406537] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 13:43:07 PDT 2020


Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 215377: Introduce ConstantSourceNode Interface
https://bugs.webkit.org/show_bug.cgi?id=215377

Attachment 406537: Patch

https://bugs.webkit.org/attachment.cgi?id=406537&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 406537
  --> https://bugs.webkit.org/attachment.cgi?id=406537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406537&action=review

> Source/WebCore/Modules/webaudio/AudioNode.h:92
> +	   NodeTypeEnd,

NodeTypeEnd should always be LAST in the enum, per its name :)


More information about the webkit-reviews mailing list