[webkit-reviews] review granted: [Bug 215440] Add settings for Copy WebKit Permalink : [Attachment 406495] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 215440: Add settings for Copy WebKit Permalink
https://bugs.webkit.org/show_bug.cgi?id=215440

Attachment 406495: Patch

https://bugs.webkit.org/attachment.cgi?id=406495&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 406495
  --> https://bugs.webkit.org/attachment.cgi?id=406495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406495&action=review

Patch looks good.

> Tools/CopyPermalink/Sublime
Text/CopyWebKitPermalink/CopyWebKitPermalink.py:38
> +class Settings:

Ok as is. Consider inherit from object.

>> Tools/CopyPermalink/Sublime
Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3
>> +	"include_revision": true,
> 
> I was tempted to have this default to `false` as it's significantly more
performant for me, but I erred on the side of caution in preserving existing
functionality.

��