[webkit-reviews] review granted: [Bug 215424] Fail preconnect requests to deprecated TLS instead of allowing application to show warning : [Attachment 406469] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 215424: Fail preconnect requests to deprecated TLS instead of allowing
application to show warning
https://bugs.webkit.org/show_bug.cgi?id=215424

Attachment 406469: Patch

https://bugs.webkit.org/attachment.cgi?id=406469&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 406469
  --> https://bugs.webkit.org/attachment.cgi?id=406469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406469&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:678
> +	   if (negotiatedLegacyTLS == NegotiatedLegacyTLS::Yes &&
task._preconnect)
> +	       return
completionHandler(NSURLSessionAuthChallengeCancelAuthenticationChallenge, nil);

Seems like we should also check the TLS deprecation feature flag here?