[webkit-reviews] review granted: [Bug 181191] Lowpass and Highpass Biquads use old formulas : [Attachment 406470] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 181191: Lowpass and Highpass Biquads use old formulas
https://bugs.webkit.org/show_bug.cgi?id=181191

Attachment 406470: Patch

https://bugs.webkit.org/attachment.cgi?id=406470&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 406470
  --> https://bugs.webkit.org/attachment.cgi?id=406470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406470&action=review

> Source/WebCore/ChangeLog:3
> +	   Lowpass and Highpass Biquads use old formulas

Please fix title now that this patch is only about the HighPass filter.

> Source/WebCore/platform/audio/Biquad.cpp:244
> +	   double alpha = sin(theta) / (2 * resonance);

Please use float for all these variables like in r265517.