[webkit-reviews] review granted: [Bug 215419] [webkitpy] Use webkitcorepy's auto installer for coverage : [Attachment 406474] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 12 15:50:55 PDT 2020
Stephanie Lewis <slewis at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 215419: [webkitpy] Use webkitcorepy's auto installer for coverage
https://bugs.webkit.org/show_bug.cgi?id=215419
Attachment 406474: Patch
https://bugs.webkit.org/attachment.cgi?id=406474&action=review
--- Comment #6 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 406474
--> https://bugs.webkit.org/attachment.cgi?id=406474
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=406474&action=review
> Tools/Scripts/webkitpy/__init__.py:31
> +AutoInstall.register(Package('toml', Version(0, 10, 1)))
Still don't like not finding dependencies automatically. Going to add a lot of
extraneous code. Why are we not using requires files?
More information about the webkit-reviews
mailing list