[webkit-reviews] review granted: [Bug 215387] REGRESSION (r265224): Web Inspector: LOCALIZED STRING NOT FOUND next to the Image checkbox in the Sources prefs panel : [Attachment 406436] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 11 17:04:08 PDT 2020
Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 215387: REGRESSION (r265224): Web Inspector: LOCALIZED STRING NOT FOUND
next to the Image checkbox in the Sources prefs panel
https://bugs.webkit.org/show_bug.cgi?id=215387
Attachment 406436: Patch
https://bugs.webkit.org/attachment.cgi?id=406436&action=review
--- Comment #20 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 406436
--> https://bugs.webkit.org/attachment.cgi?id=406436
Patch
r=me, nice work!
As a general piece of feedback it's always a good idea to include additional
info/context in the ChangeLog so that when looking back at this change in the
future there's a concise and clear explanation of what and why. Even something
as simple as "Create repeated `WI.UIString ` helper" would be helpful :)
More information about the webkit-reviews
mailing list