[webkit-reviews] review granted: [Bug 215393] REGRESSION(r?): build-webkit --inspector-frontend always builds ImageDiff : [Attachment 406422] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 15:08:20 PDT 2020


Darin Adler <darin at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 215393: REGRESSION(r?): build-webkit --inspector-frontend always builds
ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=215393

Attachment 406422: Patch

https://bugs.webkit.org/attachment.cgi?id=406422&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406422
  --> https://bugs.webkit.org/attachment.cgi?id=406422
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406422&action=review

> Tools/Scripts/build-webkit:372
> +    if (isInspectorFrontend()) {
> +	   exit exitStatus($result);
> +    }

This *is* perl, so you could us the perl one-liner style.


More information about the webkit-reviews mailing list