[webkit-reviews] review granted: [Bug 215391] Fix WaveShapperNode's waveshaping curve implementation : [Attachment 406420] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215391: Fix WaveShapperNode's waveshaping curve implementation
https://bugs.webkit.org/show_bug.cgi?id=215391

Attachment 406420: Patch

https://bugs.webkit.org/attachment.cgi?id=406420&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 406420
  --> https://bugs.webkit.org/attachment.cgi?id=406420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406420&action=review

> Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp:111
> +	       unsigned k = floor(v);
> +	       double f = v - k;

What's the rationale for converting v to an unsigned and back to a double?
That’s inefficient and I don’t think it’s needed once we’ve done the floor.