[webkit-reviews] review granted: [Bug 215032] REGRESSION(r261570): [GTK] Fails to send drop event to JavaScript : [Attachment 406378] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 215032: REGRESSION(r261570): [GTK] Fails to send drop event to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=215032

Attachment 406378: Patch

https://bugs.webkit.org/attachment.cgi?id=406378&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 406378
  --> https://bugs.webkit.org/attachment.cgi?id=406378
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406378&action=review

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:337
> +		   for (auto& type : customData.orderedTypes())
> +		       types.add(type);

Are these guaranteed to be ASCII lowercase?

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:348
> +	   return copyToVector(types);

This will yield the types in a random order, based on hashing. I think we
probably want this sorted.

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:462
> +	       const auto& customData = data[0];

Why is it correct to look only at the first item?