[webkit-reviews] review granted: [Bug 215381] Fix BiquadFilterNode's lowpass filter : [Attachment 406406] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215381: Fix BiquadFilterNode's lowpass filter
https://bugs.webkit.org/show_bug.cgi?id=215381

Attachment 406406: Patch

https://bugs.webkit.org/attachment.cgi?id=406406&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 406406
  --> https://bugs.webkit.org/attachment.cgi?id=406406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406406&action=review

> Source/WebCore/Modules/webaudio/BiquadProcessor.cpp:41
> +    , m_parameter2(AudioParam::create(context, "Q", 1, -FLT_MAX, FLT_MAX))
> +    , m_parameter3(AudioParam::create(context, "gain", 0.0, -FLT_MAX, 1541))
> +    , m_parameter4(AudioParam::create(context, "detune", 0.0, -153600,
153600))

What tests these?

> LayoutTests/webaudio/biquad-lowpass.html:18
> +window.OfflineAudioContext = window.OfflineAudioContext ||
window.webkitOfflineAudioContext;

Not sure why we need this. What happens if we leave this line of code out?