[webkit-reviews] review requested: [Bug 215382] Deferred WKUserScripts are exponentially injected on preloaded pages with frames : [Attachment 406390] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 10:46:32 PDT 2020


Sam Weinig <sam at webkit.org> has asked  for review:
Bug 215382: Deferred WKUserScripts are exponentially injected on preloaded
pages with frames
https://bugs.webkit.org/show_bug.cgi?id=215382

Attachment 406390: Patch

https://bugs.webkit.org/attachment.cgi?id=406390&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 406390
  --> https://bugs.webkit.org/attachment.cgi?id=406390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406390&action=review

> Source/WebCore/page/Frame.cpp:690
> +    for (const auto& pair : m_userScriptsAwaitingNotification)

You can use structured bindings to make this a bit nicer:

for (const auto& [world, script] : m_userScriptsAwaitingNotification)


More information about the webkit-reviews mailing list