[webkit-reviews] review granted: [Bug 215369] [css-flexbox] Only update the intrinsic height if we don't have override height : [Attachment 406375] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 08:03:17 PDT 2020


Javier Fernandez <jfernandez at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 215369: [css-flexbox] Only update the intrinsic height if we don't have
override height
https://bugs.webkit.org/show_bug.cgi?id=215369

Attachment 406375: Patch

https://bugs.webkit.org/attachment.cgi?id=406375&action=review




--- Comment #5 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 406375
  --> https://bugs.webkit.org/attachment.cgi?id=406375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406375&action=review

>>> Source/WebCore/rendering/RenderBox.cpp:2781
>>> +	 if (isFloatingOrOutOfFlowPositioned() || !parent() ||
!parent()->isFlexibleBox() || hasOverrideContentLogicalHeight())
>> 
>> I think Grid items with stretch alignment will have the same problem with
this cache. Wouldn't make more sense to just check for the
HasOverrideContentLogicalHeight and remove the clauses about flexible box ?
> 
> Right, we might eventually need it for grid too. However we cannot remove the
checks now beause that triggers an infinite recursion between
> 
> layoutBlock() <-> relayoutToAvoidWidows()
> 
> that should be fixed as part of another patch. I could include a FIXME if you
want.

Yes, please, add that FIXME.


More information about the webkit-reviews mailing list