[webkit-reviews] review granted: [Bug 215224] [WebXR] Update WebXR WPT directory : [Attachment 406090] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 01:26:25 PDT 2020


youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 215224: [WebXR] Update WebXR WPT directory
https://bugs.webkit.org/show_bug.cgi?id=215224

Attachment 406090: Patch

https://bugs.webkit.org/attachment.cgi?id=406090&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 406090
  --> https://bugs.webkit.org/attachment.cgi?id=406090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406090&action=review

> Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp:41
> +}

Could be inline

>
LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.ht
tps.html:139
> +    debug('got viewerSpace');

Is it expected logging?

>
LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.ht
tps.html:206
> +	 debug('got rAF 1');

Ditto.


More information about the webkit-reviews mailing list