[webkit-reviews] review granted: [Bug 215331] [ews] send emails as html instead of plain-text : [Attachment 406320] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Aakash Jain <aakash_jain at apple.com>'s
request for review:
Bug 215331: [ews] send emails as html instead of plain-text
https://bugs.webkit.org/show_bug.cgi?id=215331

Attachment 406320: Patch

https://bugs.webkit.org/attachment.cgi?id=406320&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 406320
  --> https://bugs.webkit.org/attachment.cgi?id=406320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406320&action=review

> Tools/BuildSlaveSupport/ews-build/send_email.py:46
> +    text = text.encode('utf-8')
> +    text = text.replace('\n', '<br>')

This seems to be missing logic to encode "<" as "<" and "&" as "&" and
other such things.

Also not sure that using "<br>" is the best way to format HTML mail.