[webkit-reviews] review granted: [Bug 215333] Shaping can be performed on glyphIDs from the wrong font : [Attachment 406322] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 215333: Shaping can be performed on glyphIDs from the wrong font
https://bugs.webkit.org/show_bug.cgi?id=215333

Attachment 406322: Patch

https://bugs.webkit.org/attachment.cgi?id=406322&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 406322
  --> https://bugs.webkit.org/attachment.cgi?id=406322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406322&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:181
> +	       const GlyphData& uppercaseGlyphData =
m_font.glyphDataForCharacter(u_toupper(character), m_run.rtl());

I suggest we use "auto&" here and/or have the local variable be the font
instead of the glyph data:

    auto glyphFont = m_font.glyphDataForCharacter(u_toupper(character),
m_run.rtl()).font;