[webkit-reviews] review granted: [Bug 215301] Align existing AudioParam API with the specification : [Attachment 406242] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215301: Align existing AudioParam API with the specification
https://bugs.webkit.org/show_bug.cgi?id=215301

Attachment 406242: Patch

https://bugs.webkit.org/attachment.cgi?id=406242&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 406242
  --> https://bugs.webkit.org/attachment.cgi?id=406242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406242&action=review

> Source/WebCore/ChangeLog:19
> +	   - Throw exceptions when events overlap. This part is based on
Chromium's implementation here:
> +	     -
https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/mod
ules/webaudio/audio_param_timeline.cc#L513

Is this not spec'd? If not, is there bug filed on the spec to add it?

> Source/WebCore/Modules/webaudio/AudioParamTimeline.h:90
> +	   double time() const { return m_time; }

It may not make sense or make bindings more troublesome, but can we use
something like WallTime/MonotonicTime for these time values?