[webkit-reviews] review granted: [Bug 215262] [GStreamer] gst-full standalone library support : [Attachment 406163] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 215262: [GStreamer] gst-full standalone library support
https://bugs.webkit.org/show_bug.cgi?id=215262

Attachment 406163: Patch

https://bugs.webkit.org/attachment.cgi?id=406163&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 406163
  --> https://bugs.webkit.org/attachment.cgi?id=406163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406163&action=review

> Source/WebKit/UIProcess/gstreamer/WebPageProxyGStreamer.cpp:45
> +#if !USE(GSTREAMER_FULL)
>      auto request =
InstallMissingMediaPluginsPermissionRequest::create(*this, details,
description);
>      if
(pageClient().decidePolicyForInstallMissingMediaPluginsPermissionRequest(reques
t.get()))
>	   return;
>  
>      request->deny();
> +#endif

#else
UNUSED_PARAM...

> Tools/ChangeLog:8
> +	   Disable GStreamer options command-line support in MiniBrowsers. This
isn't very useful and

State that this is a non-related clean-up or move it to a different patch,
please.