[webkit-reviews] review denied: [Bug 215265] We should run the tests for DataMutex : [Attachment 406287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 06:58:43 PDT 2020


Mark Lam <mark.lam at apple.com> has denied Robin Morisset <rmorisset at apple.com>'s
request for review:
Bug 215265: We should run the tests for DataMutex
https://bugs.webkit.org/show_bug.cgi?id=215265

Attachment 406287: Patch

https://bugs.webkit.org/attachment.cgi?id=406287&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 406287
  --> https://bugs.webkit.org/attachment.cgi?id=406287
Patch

Thanks for fixing the failures.  Unfortunately, I don't think we should land
this because grepping the code, I see that the DataMutex class is only used by
the gtk port.  Unless we have a reason to include it (e.g. pending use), we
should leave it out for Darwin ports.  You can close this bug as WONTFIX.


More information about the webkit-reviews mailing list