[webkit-reviews] review granted: [Bug 215183] Preload graphics drivers in Mac WebProcess : [Attachment 406236] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 15:02:50 PDT 2020


Darin Adler <darin at apple.com> has granted Ben Nham <nham at apple.com>'s request
for review:
Bug 215183: Preload graphics drivers in Mac WebProcess
https://bugs.webkit.org/show_bug.cgi?id=215183

Attachment 406236: Patch

https://bugs.webkit.org/attachment.cgi?id=406236&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 406236
  --> https://bugs.webkit.org/attachment.cgi?id=406236
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406236&action=review

> Source/WebCore/page/ProcessWarming.cpp:89
> +    GPUDevice::tryCreate(gpuRequestAdapterOptions);

Why is the local variable needed? Isn’t this the same as passing WTF::nullopt?


More information about the webkit-reviews mailing list