[webkit-reviews] review granted: [Bug 215052] Make GlyphBuffers required in the fast text codepath : [Attachment 405981] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 215052: Make GlyphBuffers required in the fast text codepath
https://bugs.webkit.org/show_bug.cgi?id=215052

Attachment 405981: Patch

https://bugs.webkit.org/attachment.cgi?id=405981&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 405981
  --> https://bugs.webkit.org/attachment.cgi?id=405981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405981&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:450
> +    // This is needed only to match the result of the slow path. Same glyph
widths but different floating point arithmentics can
> +    // produce different run width.

Existing comment just moving but:

- Would look nicer if line break was at sentence break.
- "arithmentics"

> LayoutTests/ChangeLog:8
> +	   * platform/win/fast/events/selectstart-by-drag-expected.txt: Test
progressed on Windows.

Do you know why?