[webkit-reviews] review granted: [Bug 215298] Off by one error in transform feedback buffer binding : [Attachment 406224] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 215298: Off by one error in transform feedback buffer binding
https://bugs.webkit.org/show_bug.cgi?id=215298

Attachment 406224: Patch

https://bugs.webkit.org/attachment.cgi?id=406224&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 406224
  --> https://bugs.webkit.org/attachment.cgi?id=406224
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review

>>> Source/WebCore/ChangeLog:8
>>> +	     Caught by conformance test
deqp/functional/gles3/negativebufferapi.html
>> 
>> This change is missing a test.
> 
> The test is present. The suite it's in (deqp) is currently skipped in the
test expectations because it takes a long time to run. I'm looking into whether
we can make it faster.

We have a separate bot that runs the deqp tests.