[webkit-reviews] review denied: [Bug 215269] [WTF] Remove the build warning since r265344. : [Attachment 406174] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 215269: [WTF] Remove the build warning since r265344.
https://bugs.webkit.org/show_bug.cgi?id=215269

Attachment 406174: Patch

https://bugs.webkit.org/attachment.cgi?id=406174&action=review




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 406174
  --> https://bugs.webkit.org/attachment.cgi?id=406174
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406174&action=review

Both lengthOfIntegerAsString() and another method were refactored to handle all
types in a single method, so I'd prefer to keep them that way.

> Source/WTF/wtf/text/IntegerToStringConversion.h:-119
> -    if constexpr (std::is_same_v<IntegerType, bool>)
> -	   return 1;

I think we should add UNUSED_PARAM(integer) here instead.