[webkit-reviews] review granted: [Bug 215290] [macOS] It should be possible to override spellchecking results in WebKitTestRunner : [Attachment 406207] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 215290: [macOS] It should be possible to override spellchecking results in
WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=215290

Attachment 406207: Patch

https://bugs.webkit.org/attachment.cgi?id=406207&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 406207
  --> https://bugs.webkit.org/attachment.cgi?id=406207
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406207&action=review

r=me

> LayoutTests/editing/spelling/markers.html:83
> +    element = e;

NIT: rather than declare the globals using `let`, I think you can use
`window.element = null` and then just set `window.element = element` (changing
`e` to `element`) here to avoid the naming collision/confusion :)

> LayoutTests/editing/spelling/markers.html:92
> +	   misspellingData = misspelling;

ditto (:83)

> LayoutTests/editing/spelling/markers.html:109
> +    element = e;

ditto (:83)

> LayoutTests/editing/spelling/markers.html:118
> +	   misspellingData = misspelling;

ditto (:83)

> LayoutTests/editing/spelling/markers.html:123
> +	       oppositeMarker = "spelling";

ditto (:83)

> LayoutTests/editing/spelling/markers.html:125
> +	       oppositeMarker = "grammar";

ditto (:83)