[webkit-reviews] review granted: [Bug 215293] REGRESSION(r261159) PokerBros only shows black screen : [Attachment 406216] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 14:56:17 PDT 2020


Keith Miller <keith_miller at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 215293: REGRESSION(r261159) PokerBros only shows black screen
https://bugs.webkit.org/show_bug.cgi?id=215293

Attachment 406216: Patch

https://bugs.webkit.org/attachment.cgi?id=406216&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 406216
  --> https://bugs.webkit.org/attachment.cgi?id=406216
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406216&action=review

r=me with comment.

> Source/JavaScriptCore/runtime/JSObject.cpp:519
> +    static bool isPokerBros =
CFEqual(CFBundleGetIdentifier(CFBundleGetMainBundle()),
CFSTR("com.kpgame.PokerBros"))

I forget the semantics of this? Is this only run once? I assume so but if not
this is probably going to be a perf regression.


More information about the webkit-reviews mailing list